Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formulae: remove unneeded completion base_name #201871

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
2 changes: 1 addition & 1 deletion Formula/a/ast-grep.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def install
system "cargo", "install", *std_cargo_args(path: "crates/cli")

generate_completions_from_executable(bin/"ast-grep", "completions")
generate_completions_from_executable(bin/"sg", "completions", base_name: "sg")
generate_completions_from_executable(bin/"sg", "completions")
end

test do
Expand Down
2 changes: 1 addition & 1 deletion Formula/b/bitwarden-cli.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def install

generate_completions_from_executable(
bin/"bw", "completion",
base_name: "bw", shell_parameter_format: :arg, shells: [:zsh]
shell_parameter_format: :arg, shells: [:zsh]
)
end

Expand Down
5 changes: 2 additions & 3 deletions Formula/c/cartridge-cli.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@ def install
system "mage", "build"
bin.install "cartridge"
generate_completions_from_executable(bin/"cartridge", "gen", "completion",
shells: [:bash, :zsh],
shell_parameter_format: :none,
base_name: "cartridge")
shells: [:bash, :zsh],
shell_parameter_format: :none)
end

test do
Expand Down
2 changes: 1 addition & 1 deletion Formula/c/chainloop-cli.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def install

system "go", "build", *std_go_args(ldflags:, output: bin/"chainloop"), "./app/cli"

generate_completions_from_executable(bin/"chainloop", "completion", base_name: "chainloop")
generate_completions_from_executable(bin/"chainloop", "completion")
end

test do
Expand Down
2 changes: 1 addition & 1 deletion Formula/c/cilium-cli.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def install
]
system "go", "build", *std_go_args(ldflags:, output: bin/"cilium"), "./cmd/cilium"

generate_completions_from_executable(bin/"cilium", "completion", base_name: "cilium")
generate_completions_from_executable(bin/"cilium", "completion")
end

test do
Expand Down
2 changes: 1 addition & 1 deletion Formula/c/cloudformation-guard.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class CloudformationGuard < Formula
def install
system "cargo", "install", *std_cargo_args(path: "guard")

generate_completions_from_executable(bin/"cfn-guard", "completions", "--shell", base_name: "cfn-guard")
generate_completions_from_executable(bin/"cfn-guard", "completions", "--shell")

doc.install "docs"
doc.install "guard-examples"
Expand Down
2 changes: 1 addition & 1 deletion Formula/c/cocogitto.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def install
ENV["LIBGIT2_NO_VENDOR"] = "1"

system "cargo", "install", *std_cargo_args
generate_completions_from_executable(bin/"cog", "generate-completions", base_name: "cog")
generate_completions_from_executable(bin/"cog", "generate-completions")

system bin/"cog", "generate-manpages", buildpath
man1.install Dir["*.1"]
Expand Down
2 changes: 1 addition & 1 deletion Formula/c/cri-tools.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def install
system "make", "install", "VERSION=#{version}"
end

generate_completions_from_executable(bin/"crictl", "completion", base_name: "crictl")
generate_completions_from_executable(bin/"crictl", "completion")
end

test do
Expand Down
2 changes: 1 addition & 1 deletion Formula/e/elan-init.rb
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def install
bin.install_symlink "elan-init" => link
end

generate_completions_from_executable(bin/"elan", "completions", base_name: "elan")
generate_completions_from_executable(bin/"elan", "completions")
end

test do
Expand Down
2 changes: 1 addition & 1 deletion Formula/f/fleet-cli.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def install
]
system "go", "build", *std_go_args(output: bin/"fleet", ldflags:), "./cmd/fleetcli"

generate_completions_from_executable(bin/"fleet", "completion", base_name: "fleet")
generate_completions_from_executable(bin/"fleet", "completion")
end

test do
Expand Down
Loading