mise: fix shell completion

[robinbowes]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[daeho-ro]

I think this will break for zsh and fish, only required for bash right?

[robinbowes]

I've just tested this and it only adds the extra libs if bash is specified.

So no, it doesn't break for other shells.

[rrotter]

Isn't this something that belongs in the user's .bash.rc? Looks like it's optional so the same library isn't sourced over-and-over at shell initialization. Maybe some clarification on what @jdx's (upstream) intention was with this flag would be helpful?

Additionally, does this work for both bash 3 and 5?

[jdx]

I thought homebrew had this as a separate package. How do other CLI's include it? I wouldn't think you'd want my vendored version

[robinbowes]

It appears there are two bash-completion recipes, both sourced from https://github.com/scop/bash-completion

• bash-completion (v1.3, for bash versions < 4.2)
• bash-completion@2 (v2.15.0 for bash versions 4.2+)

I imagine it may be difficult to optionally install one of these packages when mise is installed?

[robinbowes]

BTW, I can confirm that installing bash-completion@2 fixed mise completion for me (I'm on macos, but use bash 5 as my shell, installed from Homebrew).