Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pstoedit 4.02 #201507

Merged
merged 2 commits into from
Dec 21, 2024
Merged

pstoedit 4.02 #201507

merged 2 commits into from
Dec 21, 2024

Conversation

khipp
Copy link
Member

@khipp khipp commented Dec 17, 2024

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Dec 17, 2024
@khipp
Copy link
Member Author

khipp commented Dec 17, 2024 

  pstoedit.cpp:69:10: fatal error: 'link.h' file not found
     69 | #include <link.h>
        |          ^~~~~~~~
  1 error generated.
  make[1]: *** [pstoedit.lo] Error 1
  make: *** [install-recursive] Error 1

@chenrui333 chenrui333 added the build failure CI fails while building the software label Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Dec 19, 2024
@alebcay
Copy link
Member

alebcay commented Dec 20, 2024

From what I can tell, link.h and the symbols that pstoedit seems to be requesting (struct dl_phdr_info, function dl_iterate_phdr) are from glibc, not available on macOS.

@github-actions github-actions bot removed the stale No recent activity label Dec 20, 2024
@alebcay alebcay removed the build failure CI fails while building the software label Dec 20, 2024
daeho-ro
daeho-ro approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, @alebcay 👍

@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 21, 2024
Merged via the queue into Homebrew:master with commit 00479e0 Dec 21, 2024
15 checks passed
@khipp khipp deleted the bump-pstoedit-4.02 branch December 21, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeho-ro daeho-ro daeho-ro approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khipp @alebcay @daeho-ro @chenrui333 @BrewTestBot