llvm: add config file, update caveats #192709
Draft
+33
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
added
the
CI-syntax-only
github-actions
bot
added
the
python
Adding a system config file will allow us to stop baking in the `DEFAULT_SYSROOT` and allow users on Xcode-only installations to use the bottles. It will also make it easier to update this value when users upgrade the major version of their macOS. Before this change, this required a full reinstall. After, users will simply have to `brew postinstall llvm`. The config file change requires an upstream patch. We'll probably have to wait a little bit for it to merge, and then wait another few days to make sure it doesn't get reverted. Following discussion at #192505, let's also update the caveats to notify users of potential changes regarding `LLVM_ENABLE_EH` in LLVM 20.
carlocab
force-pushed
the
llvm-disable-eh-caveats
branch
from
3da97da
to
24b7c0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Adding a system config file will allow us to stop baking in the
DEFAULT_SYSROOTand allow users on Xcode-only installations to use thebottles. It will also make it easier to update this value when users
upgrade the major version of their macOS. Before this change, this
required a full reinstall. After, users will simply have to
brew postinstall llvm.The config file change requires an upstream patch. We'll probably have
to wait a little bit for it to merge, and then wait another few days to
make sure it doesn't get reverted.
Following discussion at #192505, let's also update the caveats to notify
users of potential changes regarding
LLVM_ENABLE_EHin LLVM 20.Marked as syntax-only for now to avoid duplicating the build at #192505.