Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Fix(elevation): Fix depth #317

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Fix(elevation): Fix depth #317

merged 1 commit into from
Aug 7, 2018

Conversation

martahj
Copy link
Contributor

@martahj martahj commented Aug 7, 2018 •
edited
Loading

Summary of changes:

  • Fixes the function to add elevation depth, which was
    broken by eslint.

Behaviors that should be QA'd:

  • Buttons on buttons page have correct shadow when pressed
  • Buttons on icons page have correct shadow when pressed
  • Buttons on snackbar page have correct shadow when pressed
  • Clickable chips have correct elevation when pressed

Github Issues closed by this PR:

@martahj
Fix(elevation): Fix depth
434575b 
Fixes the function to add elevation depth, which was
broken by eslint.
@merlinbot
Copy link

Messages
📖

PR Application

Generated by 🚫 dangerJS

dekkofilms
dekkofilms approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@dekkofilms dekkofilms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Don't know if using addDepth as a css function makes the most sense to me, but wasn't introduced here.

danieltisdale
danieltisdale approved these changes Aug 7, 2018
View reviewed changes
Copy link

@danieltisdale danieltisdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @martahj

ceciliamvrie
ceciliamvrie approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@ceciliamvrie ceciliamvrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@martahj martahj merged commit 1212c1f into HomeServicesOfAmerica:master Aug 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ceciliamvrie ceciliamvrie ceciliamvrie approved these changes

@dekkofilms dekkofilms dekkofilms approved these changes

@danieltisdale danieltisdale danieltisdale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martahj @merlinbot @danieltisdale @dekkofilms @ceciliamvrie