This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
feat(Tooltip): Initial implementation #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds out an initial tooltip component Resolve HomeServicesOfAmerica#47
|
A note on this PR: In the past, we've used react-tooltip for our tooltip needs. However, this implementation moves away from that because it is no longer being actively maintained and does not work cleanly with styled-components (see this issue) |
brad-decker
approved these changes
Mar 20, 2018
| import { Portal } from './Portal'; | ||
| import { Icon } from '../icons/icons'; | ||
|
|
||
| const MOBILE_MARGIN = 24; |
There was a problem hiding this comment.
Probably not now but sometime soon we need to have a group session where we identify common variables used throughout the material components implementation as well as our own library and move them into the theme or create some variables that are usable globally.
There was a problem hiding this comment.
Good idea. I opened an issue for this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds out an initial tooltip component
Resolve #47
Now link: https://docs-kjhyzertdn.now.sh