fix: improve error handling for missing output.html.print setting #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-dlee
force-pushed
the
bl-print-error-check
branch
from
47d4ba8 to
72fb9fa
Compare
HollowMan6
approved these changes
Dec 5, 2023
| @@ -9,7 +9,7 @@ license = "GPL-3.0" | |||
| name = "mdbook-pdf" | |||
| readme = "README.md" | |||
| repository = "https://github.com/HollowMan6/mdbook-pdf" | |||
| version = "0.1.7" | |||
| version = "0.1.8" | |||
There was a problem hiding this comment.
I will make a new release once headless_chrome includes my last PR rust-headless-chrome/rust-headless-chrome#439 so that I can unfork from my dependency 7250bba (should be soon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled my hair out for a few hours trying to figure out why the "pdf" backend kept failing after I had all dependencies installed. The docs indicate that
output.html.printis enabled by default. For one reason or another, this was not active forme the resulting stack trace is not very informative. This adds an error check to the code to improve the output when this circumstance is encountered.