Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Update search bar layout #295

Closed
plutonik-a opened this issue Nov 13, 2017 · 2 comments
Closed

[Search] Update search bar layout #295

plutonik-a opened this issue Nov 13, 2017 · 2 comments
Milestone
2.1 FRUS Advanced...

Comments

@plutonik-a
Copy link
Contributor

Delete current placeholder, add https://standards.usa.gov/components/search-bar/ styling with a search icon.

bildschirmfoto 2017-11-13 um 14 41 12

Parent: #284
Related: #294
@plutonik-a plutonik-a added this to the 2.1 FRUS Advanced search milestone Nov 13, 2017
@plutonik-a plutonik-a mentioned this issue Nov 13, 2017
Open
11 tasks
@joewiz
Copy link
Member

joewiz commented Nov 13, 2017

Please replace the magnifying glass icon with "Search" in the keyword search input field, as this instance appears to fall into the "medium" or "large" category in the https://standards.usa.gov/components/search-bar/ guidelines.

plutonik-a added a commit that referenced this issue Nov 13, 2017
@plutonik-a
feat(search): Update search buttons in searchbars #295
3541ae0 
* display icon on smaller screens
* display button label „Search“ on wider screens

CLoses #295
plutonik-a added a commit that referenced this issue Nov 13, 2017
@plutonik-a
fix(search): Set border color only for searchbar in menu #295
2e01b63
@plutonik-a
Copy link
Contributor Author

plutonik-a commented Nov 13, 2017 •
edited
Loading

bildschirmfoto 2017-11-13 um 18 12 07

bildschirmfoto 2017-11-13 um 18 16 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1 FRUS Advanced search
Development

No branches or pull requests
2 participants
@joewiz @plutonik-a