Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create component "Filter by Date" #288

Closed
plutonik-a opened this issue Nov 13, 2017 · 4 comments
Closed

Create component "Filter by Date" #288

plutonik-a opened this issue Nov 13, 2017 · 4 comments
Assignees
@tuurma
Labels
high priority
Milestone
2.1 FRUS Advanced...

Comments

@plutonik-a
Copy link
Contributor

plutonik-a commented Nov 13, 2017 •
edited
Loading

When section "Historical Documents" is selected, the component "filter by date" will show text inputs for typing a start and an end date, as well as a start time and an end time. All options are optional.

There is no default date or time. Inputs only display a placeholder with the required format.
mm dd yyy // hh mm

Component on search page:
bildschirmfoto 2017-11-13 um 13 37 53

Component in sidebar:
bildschirmfoto 2017-11-13 um 13 32 44

Parent: #284
Dependent on: #287
@plutonik-a plutonik-a mentioned this issue Nov 13, 2017
Open
11 tasks
@plutonik-a plutonik-a added this to the 2.1 FRUS Advanced search milestone Nov 13, 2017
@joewiz
Copy link
Member

joewiz commented Nov 13, 2017

Just one request, moved here from #284 (comment):

  • Please place the "For example" examples beneath all date and time fields (namely, Start Date, End Date, Start Time, and End Time).

@plutonik-a plutonik-a mentioned this issue Nov 16, 2017
Closed
plutonik-a added a commit that referenced this issue Nov 23, 2017
@plutonik-a
feat(search): Create template for date/time filter #288
432c36f 
* create markup as include
* apply first styling
plutonik-a added a commit that referenced this issue Nov 24, 2017
@plutonik-a
feat(search): Apply styling to date component #288
8366817 
* create adaptive styling for date/time panels: 50/50 layout on
screensizes, that allow panels to be floated next to each other, full
width otherwise, same applies if component is placed inside the sidebar.
* refactor variables for breakpoints: add min max breakpoints
* add grid class for 50/50 layout
* add headline classes
plutonik-a added a commit that referenced this issue Nov 24, 2017
@plutonik-a
feat(search): Rename form for date component #288
cdad5f4
plutonik-a added a commit that referenced this issue Nov 24, 2017
@plutonik-a
feat(search): Restructure and enhance date template #288
4ff7644
plutonik-a added a commit that referenced this issue Nov 27, 2017
@plutonik-a
fix(search): Fix breakpoint of date boxes in sidebar #288
9a11d10
plutonik-a added a commit that referenced this issue Nov 27, 2017
@plutonik-a
fix(search): Fix margins of date boxes in sidebar #288
0b90c49
plutonik-a added a commit that referenced this issue Nov 27, 2017
@plutonik-a
feat(search): Add headlines and help text to date filter #288
f92befb
plutonik-a added a commit that referenced this issue Nov 27, 2017
@plutonik-a
feat(search): Show/hide date component #288
4aa4d9f 
* show date component only if option „Historical Documents“ or „Entire
site“ is selected
*hide otherwise
* make a smooth transition when showing and hiding the date boxes
@plutonik-a
Copy link
Contributor Author

plutonik-a commented Nov 27, 2017 •
edited
Loading

Status so far: UI is ready
TODO: Correct serialization of input parameters, best as input-group-wise merged parameters.

Hidden:
bildschirmfoto 2017-11-27 um 15 40 46

Active:
bildschirmfoto 2017-11-27 um 15 41 29

@plutonik-a plutonik-a self-assigned this Nov 27, 2017
tuurma added a commit that referenced this issue Nov 27, 2017
@tuurma
fix(date filter) add templating relaed attributes and fix names; affe…
08e8908 
…cts #288
plutonik-a added a commit that referenced this issue Nov 28, 2017
@plutonik-a
fix(search): Don't display date widget, if entire site is checked #288
46dec20
@tuurma
Copy link
Contributor

tuurma commented Nov 29, 2017

ideally we want the date controls aggregated for the query string and filter badges but for the time being we will proceed with split-up-controls and join them on the backend

@tuurma tuurma assigned tuurma and unassigned plutonik-a Nov 29, 2017
plutonik-a added a commit that referenced this issue Nov 29, 2017
@plutonik-a
fix(search): Fix serialization of date parameters #288
a5f0358 
* rename input names of #dateFilter form
* serialize the form
* add divider before date parameters
plutonik-a added a commit that referenced this issue Nov 29, 2017
@plutonik-a
fix(search): Show date only if a certain input is selected #288
0f8066d 
Check, if only Historical Documents is checked and only then expand the
date widget.
tuurma added a commit that referenced this issue Nov 29, 2017
@tuurma
fix(date filter) add templating relaed attributes and fix names; affe…
8622a00 
…cts #288
tuurma added a commit that referenced this issue Nov 29, 2017
@tuurma
feat(date filter) aggregate partial date controls (mm dd yyyy) into s…
5d6ba1b 
…ingle query param and back; addresses #288
tuurma added a commit that referenced this issue Nov 29, 2017
@tuurma
fix(date filter) add templating relaed attributes and fix names; affe…
7553501 
…cts #288
tuurma added a commit that referenced this issue Nov 29, 2017
@tuurma
feat(date filter) aggregate partial date controls (mm dd yyyy) into s…
fef81e8 
…ingle query param and back; addresses #288
tuurma added a commit that referenced this issue Nov 29, 2017
@tuurma
fix(date filter) remove redundant date criteria serialization; affects …
f63f241 
…#288
plutonik-a added a commit that referenced this issue Nov 30, 2017
@plutonik-a
fix(search): Refactor date and time input IDs #288
94feca4 
* delete form class „form-control“ in date form
* delete data-template:form-control from date inputs and leave it
applied just for the hidden inputs
* refactor declaration of variables by using shorthands
* delete obsolete & commented-out code
plutonik-a added a commit that referenced this issue Nov 30, 2017
@plutonik-a
fix(search): Fix conditional display of date section #288
56830ff 
Add missing classes for triggering expanding and collapsing date
section.
plutonik-a added a commit that referenced this issue Nov 30, 2017
@plutonik-a
Merge branch 'feat-date-search' into feat-advanced-search-284
a68025e 
* feat-date-search:
  fix(search): Fix conditional display of date section #288
  fix(search): Refactor date and time input IDs #288
  feat(volumes filter) trim volume names down to subseries+volume_number+volume titles; affects #293
  fix(date filter) remove redundant date criteria serialization; affects #288
  feat(date filter) aggregate partial date controls (mm dd yyyy) into single query param and back; addresses #288
  feat(date search) first take on date search
  fix(filters) bring back checking of volumes/administrations etc, add templating attributes for date section
  fix(date filter) add templating relaed attributes and fix names; affects #288
  feat(date search) first take on date search
  feat(date search) first take on date search
  feat(date filter) aggregate partial date controls (mm dd yyyy) into single query param and back; addresses #288
  fix(filters) bring back checking of volumes/administrations etc, add templating attributes for date section
  fix(date filter) add templating relaed attributes and fix names; affects #288
  feat(date search) first take on date search
  feat(date search) first take on date search
  fix(filters) bring back checking of volumes/administrations etc, add templating attributes for date section
  fix(date filter) add templating relaed attributes and fix names; affects #288
  feat(date search) first take on date search
  feat(date search) first take on date search
  feat(date search) first take on date search
plutonik-a added a commit that referenced this issue Nov 30, 2017
@plutonik-a
fix(search): Fix correct serialization of date parameters #288 #287
c5644da 
* apply correct selector for section filters
* fix „reset filters“ of date on landing page and filters in sidebar
* delete data-template:form-control from all date inputs but hidden one
for aggregation of parameters, because the function only takes a single
value instead of a sequence
plutonik-a added a commit that referenced this issue Dec 1, 2017
@plutonik-a
fix(date search): Update hint text for example time format #288
ebd4855
@plutonik-a plutonik-a mentioned this issue Dec 4, 2017
Closed
@tuurma tuurma closed this as completed Dec 5, 2017
@tuurma
Copy link
Contributor

tuurma commented Dec 5, 2017

other related commits
e4ef537
749fd9c
1a15fd0
6590eaa
f63f241
fef81e8
b04001d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tuurma tuurma

Labels
high priority
Projects
None yet
Milestone
2.1 FRUS Advanced search
Development

No branches or pull requests
3 participants
@joewiz @tuurma @plutonik-a