Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added edX Tool and Fixed Some Bugs #666

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

divyansh-2005
Copy link
Contributor

Related Issue

[New Tool]: edX #637

Description

Changes Overview:

  • frontend/src/App.js:

    • Removed duplicate imports and elements.
    • Ensured all elements are properly closed.
    • Corrected the Preloader usage.
  • frontend/src/ChatAssistant/ChatAssistant.jsx:

    • Moved the conditional rendering of the logo outside of the {isOpen && ...} block to ensure it only renders when isOpen is false.
    • Used useState to manage the logo source (logoSrc) and updated it in the onMouseEnter and onMouseLeave event handlers to avoid direct DOM manipulation.
  • frontend/src/Component/Footer.js:

    • Removed duplicate imports.
    • Corrected duplicate elements.
    • Ensured all tags are properly closed.
    • Simplified the structure for better readability and maintenance.
  • frontend/src/DB/product.json:

    • Added new tool edX.
  • frontend/src/index.js:

    • Removed the duplicate BrowserRouter import.
    • Ensured BrowserRouter is used correctly in the root.render call.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / Videos (if applicable)

image

Checklist:

  • I have performed a self-review of my code.
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context:

  • Changed the category of BitDegree, Scaler, and Coursera from "coding" to "course".

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devlabs ❌ Failed (Inspect) Jun 10, 2024 8:36am

Copy link

vercel bot commented Jun 5, 2024

@divyansh-2005 is attempting to deploy a commit to the himanshunarware's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@divyansh-2005
Copy link
Contributor Author

"Greetings / welcome (pull_request_target) Failing after 6s"

How can I solve this error ?

@panwar8279 panwar8279 merged commit 48b6bb5 into HimanshuNarware:main Jun 10, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants