Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed images not visible in some browsers #654

Merged

Conversation

Programmer-Arvind
Copy link
Contributor

Related Issue

Fixed #569

Description

I have fixed the logos of tools that were not loading in some browsers. The tools images fixed include:

  1. w3schools
  2. Javatpoint
  3. ChatGPT Writer
  4. Himalayas
  5. KhanAcademy : The given logo was the wrong khan academy so I changed that too
  6. Figma.com
  7. flaticon
  8. Fontshare
  9. PDF24
  10. Designs.ai
  11. Walkccc
  12. DEVPOST
  13. Gitter
  14. PortSwigger
  15. CyberChef
  16. PentesterLab

Type of PR

  • Bug fix

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.

Additional context:

The reason why it did not work in some browser might be because all the above tools links are a link of the format "th.bing.com/" and it fails to get called on page load because that type of link is blocked by some browsers and extension. So this issue is fixed by changing it with different links.

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devlabs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 7:30am

Copy link

vercel bot commented Jun 4, 2024

@Programmer-Arvind is attempting to deploy a commit to the himanshunarware's projects Team on Vercel.

A member of the Team first needs to authorize it.

@HimanshuNarware
Copy link
Owner

@Programmer-Arvind share a screenshot

@Programmer-Arvind
Copy link
Contributor Author

@HimanshuNarware Thank you for pointing that out. Here is a image with some of the icons I changed bookmarked.

image

@panwar8279 panwar8279 merged commit 68eef38 into HimanshuNarware:main Jun 4, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Multiple logos not visible
3 participants