Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burger menu links #631

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Conversation

dhruv8433
Copy link
Contributor

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state "None”]

@panwar8279
[BUG]: All Navigation Link redirect to home page #599

close #599

Description

[Please include a brief description of the changes or features added]

  • i created all pages for burger menu links
  • resolve all errors and conflicts from app.js

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

image

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devlabs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 4:21am

Copy link

vercel bot commented Jun 2, 2024

@dhruv8433 is attempting to deploy a commit to the himanshunarware's projects Team on Vercel.

A member of the Team first needs to authorize it.

@dhruv8433
Copy link
Contributor Author

please check this and merge it

@dhruv8433
Copy link
Contributor Author

dhruv8433 commented Jun 2, 2024

@panwar8279

i would like to work with you
can you please assign me whole page design of all this footer and burger menu links....

i will beautifully design those pages

please check all this issues #617 #618 #619 #620 #621 #622 #623 #624 #625
i can do all this for your website

@yeolesanskruti
Copy link

@dhruv8433 , please tell me how you completed the Deployment of the devlabs on Vercel.
I am new to Vercel hence I am facing a problem with this.
Thank you.

@dhruv8433
Copy link
Contributor Author

@yeolesanskruti

can you please tell me what kind of problem you faced in development..?
you just have to create one another branch and create pr, when project mentors or owners approve this pr it autometically deployed

@yeolesanskruti
Copy link

When I deploy the repository of my fork-
Screenshot 2024-06-02 173044

I am getting a 404 error.

Also,
after creating PR - I got to know I was facing deployment issues
So I tried the above deploying many times so I am confused as I am new to Vercel.
Screenshot 2024-06-02 172837
Screenshot 2024-06-02 172849

Thank you @dhruv8433 .

@dhruv8433
Copy link
Contributor Author

@panwar8279

please check this and merge it

@HimanshuNarware
Copy link
Owner

@dhruv8433 share a 30 sec video

@dhruv8433
Copy link
Contributor Author

dhruv8433 commented Jun 4, 2024

@HimanshuNarware

please check this and merge it

DEVLAPS.Mozilla.Firefox.2024-06-04.20-33-52.mp4

@dhruv8433
Copy link
Contributor Author

@HimanshuNarware

kindly please check this and merge it

@dhruv8433
Copy link
Contributor Author

@HimanshuNarware
@panwar8279

please check this and merge it
so i can make another pr

@dhruv8433
Copy link
Contributor Author

@HimanshuNarware
@panwar8279

i completed another issue please merge this so i can make another pr

@dhruv8433
Copy link
Contributor Author

@HimanshuNarware

please merge it

@HimanshuNarware
Copy link
Owner

@dhruv8433 once review your code deployment got failed

@dhruv8433
Copy link
Contributor Author

@HimanshuNarware

now i resolve all conflicts and it is able to deploy
kindly please check it and merge it

@dhruv8433
Copy link
Contributor Author

@HimanshuNarware

please check this and merge it
i resolve all conflicts and errors
now it is ready to deploy

@panwar8279 panwar8279 merged commit 89c97ec into HimanshuNarware:main Jun 10, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: All Navigation Link redirect to home page
4 participants