Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed outdated Twitter icon to updated version X. #537

Merged
merged 3 commits into from
May 28, 2024

Conversation

PrashantAnand03
Copy link
Contributor

Related Issue

[The Twitter logo used in this project is outdated. It will be changed to the updated version. #436]

Description

[Please include a brief description of the changes or features added]
To resolve the bug with the Twitter icon, I implemented changes across three sections:

  1. Added Font Awesome JavaScript link to index.html in the public folder within the frontend directory.
  2. Inserted FontAwesome Twitter icon code into Footer.js located in the Src folder within the frontend directory.
  3. Wrote CSS code in Footer.css within the style folder inside the Src directory.
    These adjustments successfully fixed the bug.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

DEVLAPS.-.twitter.bug.mp4

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devlabs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 10:35am

Copy link

vercel bot commented May 28, 2024

@PrashantAnand03 is attempting to deploy a commit to the himanshunarware's projects Team on Vercel.

A member of the Team first needs to authorize it.

@PrashantAnand03
Copy link
Contributor Author

#436 Kindly accept the Pull Request to incorporate the changes. and please merge it.

@panwar8279 panwar8279 merged commit 685fc92 into HimanshuNarware:main May 28, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants