Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/rdmp 276 catalogue metadata #2120

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Task/rdmp 276 catalogue metadata #2120

wants to merge 18 commits into from
+2,641 −1,269

Conversation

JFriel
Copy link
Collaborator

@JFriel JFriel commented Jan 24, 2025

Proposed Change

Update Catalogue Metadata to align with HDR Gateway and Pure system
Additive only, existing fields are not removed, but may not be visible in the UI

Type of change

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update
  • Other (if none of the other choices apply)

Checklist

By opening this PR, I confirm that I have:

  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Created or updated any tests if relevant
  • Have validated this change against the Test Plan
  • Requested a review by one of the repository maintainers
  • Have written new documentation or updated existing documentation to detail any new or updated functionality and how to use it
  • Have added an entry into the changelog

@JFriel JFriel requested a review from a team January 24, 2025 13:28
@JFriel JFriel marked this pull request as ready for review January 24, 2025 13:28
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 24, 2025
View reviewed changes
Rdmp.UI/MainFormUITabs/CatalogueUI.cs Fixed Show fixed Hide fixed
Rdmp.UI/SimpleControls/EditableLabelUI.Designer.cs
/// <summary>
/// Required designer variable.
/// </summary>
private System.ComponentModel.IContainer components = null;

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field 'components' can be 'readonly'.
Rdmp.UI/SimpleControls/MultiSelectChips/Chip.Designer.cs
/// <summary>
/// Required designer variable.
/// </summary>
private System.ComponentModel.IContainer components = null;

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field 'components' can be 'readonly'.
Rdmp.UI/SimpleControls/MultiSelectChips/Chip.cs Fixed Show fixed Hide fixed
Rdmp.UI/SimpleControls/MultiSelectChips/Chip.cs
}

[System.Runtime.InteropServices.DllImport("gdi32.dll")]
private static extern IntPtr CreateRoundRectRgn(int nLeftRect, int nTopRect,

Check notice

Code scanning / CodeQL

Unmanaged code Note

Minimise the use of unmanaged code.
Rdmp.UI/SimpleControls/MultiSelectChips/Chip.cs
Comment on lines +51 to +52
this.Region = Region.FromHrgn(CreateRoundRectRgn(bounds.Left, bounds.Top,
bounds.Right, bounds.Bottom, Radius, radius));

Check notice

Code scanning / CodeQL

Calls to unmanaged code Note

Replace this call with a call to managed code if possible.
Rdmp.UI/SimpleControls/MultiSelectChips/DropdownOptionsChipDisplay.Designer.cs
/// <summary>
/// Required designer variable.
/// </summary>
private System.ComponentModel.IContainer components = null;

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field 'components' can be 'readonly'.
Rdmp.UI/SimpleControls/MultiSelectChips/DropdownOptionsChipDisplay.cs Fixed Show fixed Hide fixed
Rdmp.UI/SimpleControls/MultiSelectChips/FreeFormTextChipDisplay.Designer.cs
/// <summary>
/// Required designer variable.
/// </summary>
private System.ComponentModel.IContainer components = null;

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field 'components' can be 'readonly'.
Rdmp.UI/SimpleControls/MultiSelectChips/FreeFormTextChipDisplay.cs Fixed Show fixed Hide fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JFriel