Task/rdmp 118 Allow Excel Attacher To Read From Arbitrary Start Point #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/HicServices/RDMP into task/RDMP-118-improve-excel-attacher
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+162
to
+165
| catch (Exception) | ||
| { | ||
| h = cell.NumericCellValue.ToString(); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
jas88
requested changes
Jan 27, 2024
Rdmp.Core.Tests/DataLoad/Engine/Integration/ExcelAttacherTests.cs
Outdated
Show resolved
Hide resolved
Rdmp.Core.Tests/DataLoad/Engine/Integration/ExcelAttacherTests.cs
Outdated
Show resolved
Hide resolved
jas88
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Not all excel sheets have the data start at cell A1, sometimes there are company headers and other items we are not interested in
Solution
Allow the user to specify a row and/or column override that ignores all info prior to that row/column
The row override is indexed from 1 to match Excel's formatting.
The column override supports [a-zA-z] along with integer values (0 indexed)
To Test
Create a data load using the excel attached where the excel sheet has junk data in the first few rows/columns.
No override should cause the load to fail, setting the overrides will allow the data load to succeed