From cbd89f3e975135b3e47b09973e52eba3391f67a9 Mon Sep 17 00:00:00 2001
From: James Friel <JFriel001@dundee.ac.uk>
Date: Mon, 22 Jan 2024 10:38:42 +0000
Subject: [PATCH] tidy up

---
 Rdmp.Core/Logging/DataLoadInfo.cs     |  4 ++--
 Rdmp.Core/Logging/FileSystemLogger.cs | 15 +++++++++++----
 Rdmp.Core/Logging/TableLoadInfo.cs    |  2 +-
 3 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/Rdmp.Core/Logging/DataLoadInfo.cs b/Rdmp.Core/Logging/DataLoadInfo.cs
index f42127b964..f21a7be030 100644
--- a/Rdmp.Core/Logging/DataLoadInfo.cs
+++ b/Rdmp.Core/Logging/DataLoadInfo.cs
@@ -299,7 +299,7 @@ public void LogFatalError(string errorSource, string errorDescription)
         if (UserSettings.LogToFileSystem && !string.IsNullOrWhiteSpace(UserSettings.FileSystemLogLocation))
         {
             var logger = FileSystemLogger.Instance;
-            logger.LogEventToFile("FatalEror", [errorSource,errorDescription, statusID, ID]);
+            logger.LogEventToFile(FileSystemLogger.AvailableLoggers.FatalError, [errorSource,errorDescription, statusID, ID]);
         }
         else
         {
@@ -334,7 +334,7 @@ public void LogProgress(ProgressEventType pevent, string Source, string Descript
         if (UserSettings.LogToFileSystem && !string.IsNullOrWhiteSpace(UserSettings.FileSystemLogLocation))
         {
             var logger = FileSystemLogger.Instance;
-            logger.LogEventToFile("ProgressLog", [ID, pevent, Source, Description]);
+            logger.LogEventToFile(FileSystemLogger.AvailableLoggers.ProgressLog, [ID, pevent, Source, Description]);
         }
         else
         {
diff --git a/Rdmp.Core/Logging/FileSystemLogger.cs b/Rdmp.Core/Logging/FileSystemLogger.cs
index 520bf46bcb..4521d2693a 100644
--- a/Rdmp.Core/Logging/FileSystemLogger.cs
+++ b/Rdmp.Core/Logging/FileSystemLogger.cs
@@ -24,12 +24,20 @@ public class FileSystemLogger
     public static FileSystemLogger Instance { get { return lazy.Value; } }
 
 
+    public enum AvailableLoggers
+    {
+        ProgressLog,
+        DataSource,
+        FatalError
+    }
+
+
 
     private FileSystemLogger()
     {
         var location = UserSettings.FileSystemLogLocation;
         var config = new NLog.Config.LoggingConfiguration();
-        string[] logs = { "ProgressLog", "DataSource", "FatalError" };
+        string[] logs = System.Enum.GetNames(typeof(AvailableLoggers));
         foreach (var log in logs){
             using var nLogEntry = new NLog.Targets.FileTarget(log) { FileName = Path.Combine(location, $"{log}.log"), ArchiveAboveSize = UserSettings.LogFileSizeLimit };
             config.AddRule(LogLevel.Info, LogLevel.Info, nLogEntry);
@@ -37,11 +45,10 @@ private FileSystemLogger()
         NLog.LogManager.Configuration = config;
     }
 
-
-    public void LogEventToFile(string logType, object[] logItems)
+    public void LogEventToFile(AvailableLoggers logType, object[] logItems)
     {
         var logMessage = $"{string.Join("|", Array.ConvertAll(logItems, item => item.ToString()))}";
-        var Logger = NLog.LogManager.GetLogger(logType);
+        var Logger = NLog.LogManager.GetLogger(Enum.GetName(typeof(AvailableLoggers), logType));
         Logger.Info(logMessage);
     }
 
diff --git a/Rdmp.Core/Logging/TableLoadInfo.cs b/Rdmp.Core/Logging/TableLoadInfo.cs
index 6a972aa700..40c20e41eb 100644
--- a/Rdmp.Core/Logging/TableLoadInfo.cs
+++ b/Rdmp.Core/Logging/TableLoadInfo.cs
@@ -106,7 +106,7 @@ private void RecordNewTableLoadInDatabase(DataLoadInfo parent, string destinatio
             if (UserSettings.LogToFileSystem && !string.IsNullOrWhiteSpace(UserSettings.FileSystemLogLocation))
             {
                 var logger = FileSystemLogger.Instance;
-                logger.LogEventToFile("DataSource", [s.Source,_id ,s.UnknownOriginDate ? "" : s.OriginDate]);
+                logger.LogEventToFile(FileSystemLogger.AvailableLoggers.DataSource, [s.Source,_id ,s.UnknownOriginDate ? "" : s.OriginDate]);
             }
             else
             {