Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Menu Box #940

Open
Frankpro42 opened this issue Mar 17, 2024 · 1 comment
Open

Account Menu Box #940

Frankpro42 opened this issue Mar 17, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Frankpro42
Copy link

Describe the bug
There should be a Menu slider on MistyKat (NA) next to lucifer (NA).

To Reproduce
Steps to reproduce the behavior:

  1. Go to link
  2. Click on Yrel Icon.
  3. Top right, cursor on lucifer (NA) next to Find Player.
  4. Click on Friends and Foes.
  5. Click on MistyKat.
  6. Notice at the top right, her name doesn't appear.

Expected behavior
The Account Menu Box should appear the same as looking into a profile from Find Player and clicking on a hero portrait from a recorded game.

Screenshots
link

Desktop
Chrome version Version 122.0.6261.111

@Zemill
Copy link
Collaborator

Zemill commented Mar 17, 2024

Odd...I am able to replicate.

The code for this is the same between pages

For Match Single it uses a GroupBox for displaying Hero images with account info

<a v-if="!esport && match && playerlink && item.hero && !item.check" class="link cursor-pointer" @click="this.$redirectToProfile(item.battletag, item.blizz_id, item.region, false)" :href="`/Player/${item.battletag}/${item.blizz_id}/${item.region}`">

<a v-if="!esport && match && playerlink && item.hero && !item.check" class="link cursor-pointer" @click="this.$redirectToProfile(item.battletag, item.blizz_id, item.region, false)" :href="/Player/${item.battletag}/${item.blizz_id}/${item.region}">

And then for FriendFoe page

<a class="link" @click="this.$redirectToProfile(row.split_battletag, row.blizz_id, row.region_id, false)" :href="`/Player/${row.battletag}/${row.blizz_id}/${row.region}`" >{{ row.battletag }}</a>

<a class="link" @click="this.$redirectToProfile(row.split_battletag, row.blizz_id, row.region_id, false)" :href="/Player/${row.battletag}/${row.blizz_id}/${row.region}" >{{ row.battletag }}

Initial investigation shows no real difference between the two.

The extra player menus are handled through the this.$redirectToProfile function which calls a function out of app.js

app.config.globalProperties.$redirectToProfile = function (battletag, blizz_id, region, redirect = true) {

So the code for that shouldnt be any different between the two pages....odd

@Zemill Zemill self-assigned this Mar 17, 2024
@Zemill Zemill added the bug Something isn't working label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants