Opts cleaning #61
Merged
Opts cleaning #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shaoxiongji this could impact docs. |
added 2 commits
March 12, 2024 11:50
|
smoketested with hydra config on 1 GPU during test. Seems to be working properly. |
Waino
approved these changes
May 6, 2024
| @@ -537,10 +350,12 @@ def model_opts(parser): | |||
| group.add( | |||
| '--transformer_ff', '-transformer_ff', type=int, default=2048, help='Size of hidden transformer feed-forward' | |||
| ) | |||
| # TODO is this actually in use? | |||
There was a problem hiding this comment.
It is passed around in the code. Not sure if functional, though.
There was a problem hiding this comment.
leaving is as is for now, ideally #56 would remove that
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #60