feat(feature-activation): add transactions RFC #63
+979
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
feat/feature-activation/transactions
branch
4 times, most recently
from
4bf4b6a to
488b229
Compare
glevco
force-pushed
the
feat/feature-activation/transactions
branch
3 times, most recently
from
813a1ed to
d50a352
Compare
msbrogli
requested changes
Aug 21, 2023
projects/feature-activation/0005-feature-activation-for-transactions.md
Outdated
Show resolved
Hide resolved
projects/feature-activation/0005-feature-activation-for-transactions.md
Outdated
Show resolved
Hide resolved
projects/feature-activation/0005-feature-activation-for-transactions.md
Outdated
Show resolved
Hide resolved
projects/feature-activation/0005-feature-activation-for-transactions.md
Outdated
Show resolved
Hide resolved
glevco
force-pushed
the
feat/feature-activation/transactions
branch
3 times, most recently
from
c31f715 to
2465a8b
Compare
jansegre
reviewed
Oct 4, 2023
projects/feature-activation/0005-feature-activation-for-transactions.md
Outdated
Show resolved
Hide resolved
projects/feature-activation/0005-feature-activation-for-transactions.md
Outdated
Show resolved
Hide resolved
jansegre
previously approved these changes
Oct 5, 2023
glevco
force-pushed
the
feat/feature-activation/transactions
branch
from
2465a8b to
5262e37
Compare
glevco
force-pushed
the
feat/feature-activation/transactions
branch
2 times, most recently
from
000f40c to
f41ab7c
Compare
glevco
force-pushed
the
feat/feature-activation/transactions
branch
from
f41ab7c to
ec5eff6
Compare
msbrogli
requested changes
Jan 25, 2024
projects/feature-activation/0005-feature-activation-for-transactions.md
Outdated
Show resolved
Hide resolved
projects/feature-activation/0005-feature-activation-for-transactions.md
Outdated
Show resolved
Hide resolved
projects/feature-activation/0005-feature-activation-for-transactions.md
Outdated
Show resolved
Hide resolved
|
|
||
| Therefore, the mutability of transaction parents is not an issue for the solution proposed in this document. | ||
|
|
||
| ## Selection of transaction parents |
There was a problem hiding this comment.
Same here: move to the Guide-level explanation.
There was a problem hiding this comment.
I also think that this is just an implementation detail that should be in the reference level, not guide level.
There was a problem hiding this comment.
We must at least mention that the parent selection will be critical to enable new features. Even though the DAG width is usually low, it might happen to be high and transactions might fail due to a poor parent selection. The low level should cover on the details of how this selection should take place. This part is critical for wallets. In the low leve, we might even consider to make the full node select nodes that have activated features (instead of simply randomly choosing from the tips).
glevco
force-pushed
the
feat/feature-activation/transactions
branch
from
ec5eff6 to
c46bfbd
Compare
glevco
force-pushed
the
feat/feature-activation/transactions
branch
from
c46bfbd to
b631014
Compare
msbrogli
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Acceptance Criteria
ATTENTION: @msbrogli @jansegre it's not necessary to read all 4 files in this PR, only the rendered one linked above. The other two files are incomplete/wrong ideas that are kept just for reference.