Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Persistent Mask Crash on Talking to Postman #969

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

zodiac-ill
Copy link
Contributor

@zodiac-ill zodiac-ill commented Jan 26, 2025

Persistent Masks implementer forgot to include Player pointer as argument for GI SHOULD call at z_en_mm3.c line 470. Also edits PersistentMasks.cpp to prevent null deref.

To reproduce this crash, simply turn on Persistent Bunny Hood and talk to the postman while he is on bed.

Build Artifacts

@Archez Archez merged commit be93caa into HarbourMasters:develop Jan 26, 2025
5 checks passed
@zodiac-ill zodiac-ill deleted the fix-persistentmasks-crash branch January 26, 2025 23:02
@Eblo Eblo mentioned this pull request Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants