Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caching from CVar prefix defines #966

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Jan 24, 2025

These should not be cached, it could lead to weird behavior for local dev.

Build Artifacts

@Malkierian
Copy link
Contributor

Do they still work as-is with the rest of it, though? As I recalled, I had trouble with it as anything but cached. The way to reset them in local dev is just with a --fresh in the setup command.

@Malkierian
Copy link
Contributor

The real solution to this, now that I know more about CMake, might just be setting it up with the Option flow instead, but that would also require a change to LUS to match.

@Archez
Copy link
Contributor Author

Archez commented Jan 24, 2025

Yeah that is the issue here. They should not be cache vars on LUS side, but instead option with defaults, then ports use set like I have here in the PR.

From my testing (confirmed on mac and windows), my cache entry has the "old/bad" values, but with this PR the real values are still used. So this should be good to merged, but in general a PR to LUS is also preferred as well.

Per CMake docs:

Note: The content of the cache variable will not be directly accessible if a normal variable of the same name already exists (see rules of variable evaluation).

@Archez Archez merged commit 8b7513c into HarbourMasters:develop Jan 24, 2025
5 checks passed
@Archez Archez deleted the uncache-cvar-prefix branch January 24, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants