[Enhancement] Receive oceanside spider house wallet reward on any day #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lscholte
force-pushed
the
wallet-reward-any-day
branch
2 times, most recently
from
0e11640 to
31b3466
Compare
lscholte
force-pushed
the
wallet-reward-any-day
branch
from
31b3466 to
4315c3b
Compare
46 tasks
Eblo
reviewed
Mar 1, 2025
| switch (day) { | ||
| case 0: // first day | ||
| if (CHECK_WEEKEVENTREG(WEEKEVENTREG_RECEIVED_OCEANSIDE_WALLET_UPGRADE)) { | ||
| if (!CHECK_WEEKEVENTREG(WEEKEVENTREG_RECEIVED_OCEANSIDE_WALLET_UPGRADE) && |
There was a problem hiding this comment.
Instead of directly using the CVar in the actor file, you should create a new VB, wrap the affected logic with a GameInteractor_Should call, and handle the custom logic in a new enhancement file. One example you could look at is your very own VB_DEKU_GUARD_SHOW_SEARCH_BALLS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wallet reward for clearing the oceanside spider house is normally only obtainable on the first day. This enhancement will allow the wallet reward to be collected on any day.
I'm also not sure if this would better in a different section. Perhaps restorations because this enhancement does recreate MM3D behaviour?
Build Artifacts