Add initial Sail implementation #790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjoecox
force-pushed
the
add-initial-sail-implementation
branch
2 times, most recently
from
d774bbf to
9c13f54
Compare
Archez
reviewed
Oct 5, 2024
garrettjoecox
force-pushed
the
add-initial-sail-implementation
branch
2 times, most recently
from
796eda0 to
59735b4
Compare
garrettjoecox
force-pushed
the
add-initial-sail-implementation
branch
from
59735b4 to
6b984bf
Compare
garrettjoecox
force-pushed
the
add-initial-sail-implementation
branch
from
6b984bf to
ee47074
Compare
Archez
reviewed
Dec 29, 2024
Comment on lines
+357
to
+365
| { DISABLE_FOR_SAIL_FORM_INVALID, | ||
| { [](disabledInfo& info) -> bool { | ||
| return !(!isStringEmpty(CVarGetString("gNetwork.Sail.Host", "127.0.0.1")) && | ||
| CVarGetInteger("gNetwork.Sail.Port", 43384) > 1024 && | ||
| CVarGetInteger("gNetwork.Sail.Port", 43384) < 65535); | ||
| }, | ||
| "Invalid Host/Port" } }, | ||
| { DISABLE_FOR_SAIL_ENABLED, | ||
| { [](disabledInfo& info) -> bool { return Sail::Instance->isEnabled; }, "Sail is Enabled" } }, |
There was a problem hiding this comment.
This use of Sail:: needs to be wrapped in an ifdef to prevent compile errors with networking off. Not sure if it makes sense to just ifdef out the two disable options all together, or just force the return value to false.
There was a problem hiding this comment.
I think what I'm going to instead do is only #ifdef the SDL touch points within network.cpp, and leave the rest in place leaving it visually disabled without BUILD_NETWORKING
garrettjoecox
force-pushed
the
add-initial-sail-implementation
branch
from
ee47074 to
e128749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of differences from the implementation in SoH
Build Artifacts