replaced 2x array.splice() with loop

HansAcker · Jan 9, 2025 · 8703295 · 8703295
1 parent b9d8a4d
commit 8703295
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/html/js/statsbox.js b/html/js/statsbox.js
@@ -79,7 +79,7 @@ class StatsBox {
 class SortedStatsBox extends StatsBox {
 	inc(key) {
 		if (this.has(key)) {
-			const idxOld = this._stats[key];
+			let idxOld = this._stats[key];
 			const stat = this._rows[idxOld];
 
 			stat.value++;
@@ -94,8 +94,14 @@ class SortedStatsBox extends StatsBox {
 
 			if (idxNew != idxOld) {
 				this._rows[idxNew].tr.before(stat.tr); // move table row
-				this._rows.splice(idxOld, 1); // cut
-				this._rows.splice(idxNew, 0, stat); // paste
+
+				// shift array back by one
+				while (idxOld > idxNew) {
+					this._rows[idxOld] = this._rows[idxOld-1];
+					idxOld--;
+				}
+
+				this._rows[idxNew] = stat;
 
 				//console.log(`${key}: ${this._stats[key]} => ${idxNew}`);
 				this._stats[key] = idxNew;

diff --git a/html/js/statsbox.min.js b/html/js/statsbox.min.js