Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on bcpkix-jdk15on introduces vulnerability CVE-2023-33201 #387

Closed
tadhgpearson opened this issue Oct 6, 2023 · 2 comments · Fixed by #388
Closed

Dependency on bcpkix-jdk15on introduces vulnerability CVE-2023-33201 #387

tadhgpearson opened this issue Oct 6, 2023 · 2 comments · Fixed by #388

Comments

@tadhgpearson
Copy link
Contributor

tadhgpearson commented Oct 6, 2023

Describe the bug
sslcontext-kickstart-for-pem depends on BouncyCastle bcpkix-jdk15on v1.7.0, which contains vulnerability CVE-2023-33201. This is the latest version of this module, and is not longer maintained because BC supports only LTS versions of Java (versions 8 and up).

If you run Snyk, Blackduck or other vulnerability scan on this module, the compliance alarms will go off. See also https://mvnrepository.com/artifact/org.bouncycastle/bcprov-jdk15on

Expected behavior
I'm using this software to make my life easier but compliance people are coming after me. This doesn't make my life easier :D

Additional context
Suggest you drop support for Java versions < 8, by upgrading your BouncyCastle dependency to bcpkix-jdk18on v1.7.6 which is not vulnerable.

Other readers, note that you can work around this in the current version by changing you Maven dependency as so

		<dependency>
			<groupId>io.github.hakky54</groupId>
			<artifactId>sslcontext-kickstart-for-pem</artifactId>
			<version>8.1.6</version>
			<!-- Begin temporary fix for CVE-2023-33201 -->
			<exclusions>
				<exclusion>
					<groupId>org.bouncycastle</groupId>
					<artifactId>bcpkix-jdk15on</artifactId>
				</exclusion>
			</exclusions>
		</dependency>
		<dependency>
			<groupId>org.bouncycastle</groupId>
			<artifactId>bcpkix-jdk18on</artifactId>
			<version>1.76</version>
			<!-- End temporary fix for CVE-2023-33201 -->
		</dependency>

This will keep your compliance dept ✅

tadhgpearson pushed a commit to tadhgpearson/sslcontext-kickstart that referenced this issue Oct 6, 2023
@Hakky54 Hakky54 linked a pull request Oct 6, 2023 that will close this issue
@Hakky54
Copy link
Owner

Hakky54 commented Oct 6, 2023

Hi Tadhg, it has been awhile, maybe 2 years since your previous bug report. How are you doing?

Awesome that you shared this fix. I was assuming BC would fix it and I was waiting for the new version while not being aware that they have a java 8 version of their maven artifact which does not have the bug. Thank you for creating the pull request. I will make a release this week.

@Hakky54
Copy link
Owner

Hakky54 commented Oct 7, 2023

@tadhgpearson I just released a new version containing this fix. You can use 8.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants