You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If yes, do nothing (which allows for the user to pass in -tx anything.com to change the tx server)
If no, then send -tx n/a to the Java command.
Note that in the case of (3), the user can still provide -tx anything.com, but the Java command will end up being java -jar publisher.jar -ig . -tx n/a -tx anything.com, which causes the publisher to run without a tx server.
I believe the logic should be modified to be the following:
Check if GET captive.apple.com returns 200
If no, send -tx n/a to the Java command and warn the user
If yes:
Check to see if GET $tx_server returns 200. $tx_server is whatever is passed by the user with the -tx option, or the default. (The default should be set as a variable at the top of the script so it's easy for a user to change without mucking around in the logic.)
If no, send -tx n/a to the Java command and warn the user
If yes, send -tx $tx_server to the Java command
The goal of this is to solve the problem of not being able to use an alternate tx server if the default one is completely down. I suggested a simpler fix for this in #5, but that approach fails to check for the tx server being online.
The text was updated successfully, but these errors were encountered:
The current logic is:
GET tx.fhir.org
returns 200-tx anything.com
to change the tx server)-tx n/a
to the Java command.Note that in the case of (3), the user can still provide
-tx anything.com
, but the Java command will end up beingjava -jar publisher.jar -ig . -tx n/a -tx anything.com
, which causes the publisher to run without a tx server.I believe the logic should be modified to be the following:
GET captive.apple.com
returns 200-tx n/a
to the Java command and warn the userGET $tx_server
returns 200.$tx_server
is whatever is passed by the user with the-tx
option, or the default. (The default should be set as a variable at the top of the script so it's easy for a user to change without mucking around in the logic.)-tx n/a
to the Java command and warn the user-tx $tx_server
to the Java commandThe goal of this is to solve the problem of not being able to use an alternate tx server if the default one is completely down. I suggested a simpler fix for this in #5, but that approach fails to check for the tx server being online.
The text was updated successfully, but these errors were encountered: