Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) API chat controller json return types #4473

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

Roardom
Copy link
Collaborator

@Roardom Roardom commented Feb 11, 2025

Makes static analysis happy.

Makes static analysis happy.
Copy link

what-the-diff bot commented Feb 11, 2025

PR Summary

  • Consistent JSON Response Format
    Updated the return types of several methods to 'JsonResponse' to guarantee uniformity in the format of responses.
  • Explicit JSON Responses
    Directly specifying JSON responses instead of general ones to increase clarity of our code.
  • Simplification of Methods
    Eliminated the need for comments related to automatic JSON conversion, making our method implementations simpler and cleaner.

@HDVinnie HDVinnie merged commit 9fb69e1 into HDInnovations:8.x.x Feb 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants