Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) User earnings torrent count query #4472

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

Roardom
Copy link
Collaborator

@Roardom Roardom commented Feb 11, 2025

Supposedly sql doesn't support referencing outer tables while inside a FROM clause. Mariadb seems to have an issue with this - but only on some databases. Not sure why.

Copy link

what-the-diff bot commented Feb 11, 2025

PR Summary

  • New Usage of Peer Model: An import statement was added to make use of the 'Peer' model, indicating that this model is needed for some of the changes.
  • Function Alteration: The bonEarnings function's output has been changed to a more standard type, hoping to increase functionality.
  • Query Process Reworked: The new method for aggregating data from multiple sources into one query improves performance and efficiency.
  • Simpler Torrent Counting: The way we figure out how many torrents there are has been streamlined which should make the process faster and clearer.
  • Mapping Counts to Objects: Use of mapping function to assign torrent counts to each 'bonEarning' object, ensuring every item has an accurate count.
  • Commenting Update: Changes to comments on the 'torrents' method reflect its new output, so future developers have accurate information when digging into the code.

@Roardom Roardom force-pushed the fix-mariadb-user-earnings branch from a160da1 to a0f2226 Compare February 11, 2025 06:08
Supposedly sql doesn't support referencing outer tables while inside a FROM clause. Mariadb seems to have an issue with this - but only on some databases. Not sure why.
@Roardom Roardom force-pushed the fix-mariadb-user-earnings branch from a0f2226 to 21edfbd Compare February 11, 2025 06:52
@Roardom Roardom marked this pull request as ready for review February 14, 2025 03:58
@HDVinnie HDVinnie merged commit d2ffdad into HDInnovations:8.x.x Feb 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants