Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Don't hide existing sidebar if main is empty #4470

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

Roardom
Copy link
Collaborator

@Roardom Roardom commented Feb 10, 2025

A nice cleanup overall.

  • @section('content') -> @section('main')
  • @extends('layout.default') -> @extends('layout.with-main')
  • @extends\('layout.with-main'\)((.|[\n])*)@section\('sidebar'\) -> @extends('layout.with-main-and-sidebar')$1@section('sidebar')

Plus, removed the unintentional double div nesting in livewire components that include a sidebar.

Fixes #3987

@HDVinnie HDVinnie merged commit 2cce5c7 into HDInnovations:8.x.x Feb 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants