refactor: don't use unnecessary orderByRaw

Null values are always ordered last anyways. Additionally, count(*) returns 0, not null. Also fixes issue on mariadb with value being a reserved keyword.
HDInnovations · Feb 11, 2025 · 5e8f54f · 5e8f54f
1 parent e45231b
commit 5e8f54f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/app/Http/Livewire/TopUsers.php b/app/Http/Livewire/TopUsers.php
@@ -139,7 +139,7 @@ final public function commenters(): \Illuminate\Support\Collection
             ->where('user_id', '!=', User::SYSTEM_USER_ID)
             ->where('anon', '=', false)
             ->groupBy('user_id')
-            ->orderByRaw('COALESCE(value, 0) DESC')
+            ->orderByDesc('value')
             ->take(8)
             ->get();
     }
@@ -154,7 +154,7 @@ final public function posters(): \Illuminate\Support\Collection
             ->select(DB::raw('user_id, COUNT(user_id) as value'))
             ->where('user_id', '!=', User::SYSTEM_USER_ID)
             ->groupBy('user_id')
-            ->orderByRaw('COALESCE(value, 0) DESC')
+            ->orderByDesc('value')
             ->take(8)
             ->get();
     }
@@ -169,7 +169,7 @@ final public function thankers(): \Illuminate\Support\Collection
             ->select(DB::raw('user_id, COUNT(user_id) as value'))
             ->where('user_id', '!=', User::SYSTEM_USER_ID)
             ->groupBy('user_id')
-            ->orderByRaw('COALESCE(value, 0) DESC')
+            ->orderByDesc('value')
             ->take(8)
             ->get();
     }