Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call find_package once, by default module mode for zlib #5284

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Only call find_package once, by default module mode for zlib #5284

merged 2 commits into from
Jan 31, 2025

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Jan 30, 2025 •
edited
Loading

Merge from #5280

@byrnHDF byrnHDF added Merge Use this label when a PR is for a downstream merge Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Component - Build CMake, Autotools Type - Bug / Bugfix Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub Type - Improvement Improvements that don't add a new feature or functionality Component - Misc Anything else (CODEOWNERS, etc.) HDF5 1.14.6 Changes for HDF5 1.14.6 release labels Jan 30, 2025
@byrnHDF byrnHDF self-assigned this Jan 30, 2025
@lrknox
Copy link
Collaborator

lrknox commented Jan 31, 2025

tested again on macmini-m1 (macOS 15.3) and delta (Linux 4.18.0-477.81.1.el8_8.x86_64) after last change. System zlib still found on both, system libaec also found on delta (not installed on macmini-m1).

@lrknox lrknox merged commit 3d07387 into HDFGroup:hdf5_1_14_6 Jan 31, 2025
64 checks passed
@jhendersonHDF jhendersonHDF mentioned this pull request Jan 31, 2025
Merged
@byrnHDF byrnHDF deleted the hdf5_1_14_6-zlib branch February 6, 2025 13:18
@jhendersonHDF jhendersonHDF mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrknox lrknox lrknox approved these changes

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Component - Misc Anything else (CODEOWNERS, etc.) HDF5 1.14.6 Changes for HDF5 1.14.6 release Merge Use this label when a PR is for a downstream merge Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Bug / Bugfix Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byrnHDF @lrknox