Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning errors instead of panicking #3

Open
robinkrahl opened this issue Aug 13, 2022 · 0 comments
Open

Returning errors instead of panicking #3

robinkrahl opened this issue Aug 13, 2022 · 0 comments

Comments

@robinkrahl
Copy link

MountInfo::new() panics if the mountinfo file contains unexpected data. I think it would be more appropriate to return an error instead and let the caller decide how to handle it. std::io::ErrorKind::InvalidData would be a potential error variant. What do you think? Would you accept a PR with this change?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robinkrahl