test[cartesian]: conditional xfail instead of two tests #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twicki
reviewed
Feb 25, 2025
tests/cartesian_tests/integration_tests/multi_feature_tests/test_code_generation.py
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
romanc
changed the title
xfail
|
Sorry for the changes after review request. I just realized that pytest will - by default - not complain very loudly if |
havogt
reviewed
Feb 25, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
romanc
force-pushed
the
romanc/xfail-test-cleanup
branch
from
1a161dc to
de4f84f
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Follow-up from PR GridTools#1882 to merge test cases, which only differ in their expected outcome. With this PR, we'll have a single test case with conditional xfail instead.
romanc
force-pushed
the
romanc/xfail-test-cleanup
branch
from
de4f84f to
31d50d3
Compare
romanc
changed the title
xfail
|
Sorry for the back and forth. I was starting to mix things in this PR. Let's use this PR strictly for merging the two test cases and then talk in PR #1888 about enabling |
|
cscs-ci run |
|
Can someone with write access to give the green light here? Thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up from PR #1882 to merge two test cases which only differed in the expected outcome. With this PR, we'll have one single test case with a conditional
xfailas @havogt proposed in the GridTools slack channel.Related issue: #1881
Requirements
N/A