bug[next]: Respect evaluation order in InlineCenterDerefLiftVars
#1883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
InlineCenterDerefLiftVars
pass to respect evaluation order by lazily evaluating the inlined values.Consider the following case that is common in boundary conditions:
Then var should only be dereferenced in case
·on_bc
evalutes to False. Previously we just evaluated all values unconditionally:Now we instead create a 0-ary lambda function for
_icdlv_1
and evaluate it when the value is needed.Note that as a result we do evaluate the function multiple times. To avoid redundant recompuations usage of the common subexpression elimination is required.