Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: stick to supported device types #1879

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

romanc
Copy link
Contributor

@romanc romanc commented Feb 20, 2025

Description

Following the YAGNI principle, stick to the device types that are actually supported in the codebase. We can add support for other devices later.

@havogt as discussed the other day, let's have a discussion about whether or not we need all these device types defined. I know that @FlorianDeconinck would like to work towards over protection and throwing errors rather sooner than later for unsupported things (very much in general).

This is part of a clean-up series tracked in issue #1880.

Requirements

  • All fixes and/or new features come with corresponding tests.
    N/A
  • Important design decisions have been documented in the appropriate ADR inside the docs/development/ADRs/ folder.
    N/A

Following the YAGNI principle, stick to the device types that are
actually supported in the codebase. We can add support for other devices
later.
@romanc romanc marked this pull request as ready for review February 20, 2025 13:58
@FlorianDeconinck
Copy link
Contributor

cscs-ci run

@FlorianDeconinck
Copy link
Contributor

So from our side, obviously we aren't anywhere near starting to look at those architectures (to my great dismay). ROCm and CUDA are the only two device. Managed & Pinned will become a mid term subject, but again, not there yet.

@FlorianDeconinck
Copy link
Contributor

cscs-ci run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants