feat[next]: Flatten as_fieldop tuple arguments
#1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehrengruber
commented
Feb 20, 2025
| return let_expr | ||
|
|
||
|
|
||
| def unwrap_scan(stencil: itir.Lambda | itir.FunCall): |
There was a problem hiding this comment.
This function has been moved, the only addition is the _remove_let_alias call.
tehrengruber
commented
Feb 20, 2025
| @@ -71,3 +71,79 @@ def is_equal(a: itir.Expr, b: itir.Expr): | |||
| return a == b or ( | |||
| CannonicalizeBoundSymbolNames.apply(a) == CannonicalizeBoundSymbolNames.apply(b) | |||
| ) | |||
|
|
|||
|
|
|||
| def canonicalize_as_fieldop(expr: itir.FunCall) -> itir.FunCall: | |||
There was a problem hiding this comment.
This function has only been moved without changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new transformation in the collapse tuple pass that transforms all tuple arguments of an
as_fieldopinto multiple arguments, one for each element:(⇑(λ(it) → (·it)[1]))({1, 2})into
(⇑(λ(__ct_flat_el0_it, __ct_flat_el1_it) → ·__ct_flat_el1_it))(1, 2)Depends on #1868