style[cartesian]: fixing typos #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanc
commented
Jan 22, 2025
| @@ -62,8 +62,6 @@ def parameter_names(self) -> Set[str]: | |||
| def make_args_data_from_gtir(pipeline: GtirPipeline) -> ModuleData: | |||
| """ | |||
| Compute module data containing information about stencil arguments from gtir. | |||
|
|
|||
| This is no longer compatible with the legacy backends. | |||
There was a problem hiding this comment.
@FlorianDeconinck: I asked @twicki yesterday and he said there were old/legacy backends back then, in a land before time. In current times, I think this comment is more confusing then helping.
There was a problem hiding this comment.
Well even if it was true "Legacy backends" is not a very useful description. Hell, the coffee I drunk yesterday could be consider legacy.
|
@FlorianDeconinck sorry to bother you again with this. Can you formally approve? Apparently, Tobias' approval is not good enough for merging 😭
|
FlorianDeconinck
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing typos (in comments) in the cartesian part of the codebase. No code was touched.
Requirements