-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[next]: Extend and refactor constant folding #1810
Open
SF-N
wants to merge
56
commits into
GridTools:main
Choose a base branch
from
SF-N:constant_folding_main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstant_folding_main
…nstant_folding_main
… constant_folding_main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following new transformations are introduced:
literal, symref
->symref, literal
, prerequisite for FOLD_FUNCALL_LITERAL, FOLD_NEUTRAL_OPliteral, funcall
->funcall, literal
, prerequisite for FOLD_FUNCALL_LITERAL, FOLD_NEUTRAL_OPfuncall, op
->op, funcall
for s[0] + (s[0] + 1), prerequisite for FOLD_MIN_MAX_PLUSa - b
->a + (-b)
, prerequisite for FOLD_MIN_MAX_PLUSmaximum(a, maximum(...))
->maximum(maximum(...), a)
, prerequisite for(a + 1) + 1
->a + (1 + 1)
maximum(maximum(a, 1), a)
->maximum(a, 1)
maximum(maximum(a, 1), 1)
->maximum(a, 1)
maximum(plus(a, 1), a)
->plus(a, 1)
maximum(plus(a, 1), plus(a, -1))
->plus(a, maximum(1, -1))
a + 0
->a
,a * 1
->a
In the end, unary minuses are transformed back to
minus
-calls where possible byUndoCanonicalizeMinus
:a + (-b)
->a - b
,-a + b
->b - a
,-a + (-b)
->-a - b
In addition the pass now transforms until a fixed point is reached (like in the
CollapseTuple
pass) instead of just transforming once. TheFixedPointTransformation
class from PR 1826 is used here.Previously, large nested maximum expressions like
maximum(maximum(maximum(maximum(sym, 1),...), 1), maximum(maximum(sym, 1), 1))
caused timeouts in PMAP-GO as the runtime of the domain inference increased significantly due to the large domain expressions that could not be simplified.This replaces this PR.