style[cartesian]: Remove unused optional keyword arguments #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two keyword arguments aren't used in the function. Since the two functions have a "catch-all" `*kwargs` at the end of the argument list, we can safely delete the unused keyword arguments.
FlorianDeconinck
approved these changes
Jan 20, 2025
havogt
reviewed
Jan 20, 2025
No need to pass down the loop order of a `VerticalLoop`. It is never used/access inside `VerticalLoopSection`s or `HorizontalExecution`s.
|
(please squash the two commit into one when merging) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These two keyword arguments aren't used in the function. Since the two functions have a "catch-all"
*kwargsat the end of the argument list, we can safely delete the unused keyword arguments.Requirements
mypyand/or existing tests would complain if these changes weren't appropriateN/A