Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test[next]: fix obsolete asarray #1436

Merged
merged 3 commits into from
Jan 31, 2024
Merged

test[next]: fix obsolete asarray #1436

merged 3 commits into from
Jan 31, 2024

Conversation

havogt
Copy link
Contributor

@havogt havogt commented Jan 31, 2024

No description provided.

@havogt havogt requested a review from tehrengruber January 31, 2024 10:10
tehrengruber
tehrengruber approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@tehrengruber tehrengruber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now understand my recollection of this error again. This test unconditionally passes:

gt4py/tests/next_tests/integration_tests/feature_tests/ffront_tests/test_execution.py

Line 476 in 182dfa1

ref=np.full_like(offset_field, True, dtype=bool),
It's a minor thing though... Just doing np.full_like(offset_field.ndarray, True, dtype=bool) should be enough. Other than that it looks good.

@havogt havogt merged commit 6262708 into GridTools:main Jan 31, 2024
28 checks passed
@havogt havogt deleted the remove_obsolete_asarray branch January 31, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehrengruber tehrengruber tehrengruber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@havogt @tehrengruber