Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[next]: add tests with mesh with skip values #1433

Merged
merged 9 commits into from
Jan 31, 2024
Merged

feat[next]: add tests with mesh with skip values #1433

merged 9 commits into from
Jan 31, 2024

Conversation

havogt
Copy link
Contributor

@havogt havogt commented Jan 30, 2024 •
edited
Loading

  • Adds a mesh with skip values
  • Define common.SKIP_VALUE = -1 instead of using -1 explicitly
  • Skip tests with that mesh in embedded (will come in a next PR).

@havogt havogt requested a review from egparedes January 31, 2024 11:49
egparedes
egparedes reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Just a couple of questions and suggestions.

egparedes
egparedes approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one final comment but it's fully optional. Approved.

tests/next_tests/integration_tests/feature_tests/ffront_tests/ffront_test_utils.py Outdated
c2e_arr, Cell, Edge, 4, has_skip_values=False
),
},
) # type: ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of type: ignore you could also cast to MeshDescriptor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copy pasted this from the previous code. We don't check in tests, therefore it was obsolete...

@havogt havogt merged commit adf3a3c into GridTools:main Jan 31, 2024
48 checks passed
@havogt havogt deleted the add_skip_value_mesh branch January 31, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egparedes egparedes egparedes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@havogt @egparedes