feature[next]: Make gtfn cache path configurable #1406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
changed the title
DropD
reviewed
Jan 15, 2024
There was a problem hiding this comment.
The benefit of this design is obvious: a custom path can now be set.
On the other hand, this does not tick any of the boxes in https://hackmd.io/2l_ut1O-Q3ilK1IZboSryA and that project exists to avoid heaping more ad-hoc customizability on top of this system.
|
Also, changing the interface from explicitly stating the desire for a cache that does or doesn't stick around after the run (and get in the way of debugging) to passing a path and implicitly determining the lifetime by where that path is on the FS could be seen as a usability degradation. |
tehrengruber
added a commit
to tehrengruber/gt4py
that referenced
this pull request
Feb 27, 2024
|
Superseeded by #1438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description to follow