GSF-13 Do not use Microsoft.Owin.Security base classes for AuthenticationMiddleware #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthenticationHandler
does not depend on any of the underlying logic in theMicrosoft.Owin.Security
base classes. Removing them helps to simplify the code a bit inAuthenticationHandler
. Furthermore, although we have not determined the root cause of the major performance issues we are seeing on client systems, testing suggests we can very likely avoid it by removing these base classes from the Owin pipeline.Changes basically consist of implementing a handful of properties that were provided by the base classes, some minor cleanups in
AuthenticationHandler
methods, and implementing theAuthenticationMiddleware.Invoke()
method. Nothing changes about how the middleware is used, so there should be no breaking changes downstream.