Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSF-13 Do not use Microsoft.Owin.Security base classes for AuthenticationMiddleware #358

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

StephenCWills
Copy link
Member

AuthenticationHandler does not depend on any of the underlying logic in the Microsoft.Owin.Security base classes. Removing them helps to simplify the code a bit in AuthenticationHandler. Furthermore, although we have not determined the root cause of the major performance issues we are seeing on client systems, testing suggests we can very likely avoid it by removing these base classes from the Owin pipeline.

Changes basically consist of implementing a handful of properties that were provided by the base classes, some minor cleanups in AuthenticationHandler methods, and implementing the AuthenticationMiddleware.Invoke() method. Nothing changes about how the middleware is used, so there should be no breaking changes downstream.

@StephenCWills StephenCWills changed the title Do not use Microsoft.Owin.Security base classes for AuthenticationMiddleware GSF-13 Do not use Microsoft.Owin.Security base classes for AuthenticationMiddleware Jan 31, 2025
@StephenCWills StephenCWills merged commit ef34123 into master Jan 31, 2025
3 checks passed
@StephenCWills StephenCWills deleted the simplify-authentication-handler branch January 31, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants