Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic per-folder config system #40

Draft
wants to merge 30 commits into
base: dev
Choose a base branch
from
Draft

Conversation

AFCMS
Copy link
Contributor

@AFCMS AFCMS commented Apr 4, 2023

@GreenXenith

Basic per folder config system.

Partial fix for #35

EDIT: Fixed Still lacks JSON schema validation since only one feature is present in the file yet.

try {
//const content = fs.readFileSync(configPath, { encoding: "utf-8" });
//const parsedContent = JSON.parse(content);
fs.writeFileSync(configPath, JSON.stringify(c, undefined, 4));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON indentation should follow VScode settings. Will fix.

src/config/index.ts Outdated Show resolved Hide resolved
@AFCMS
Copy link
Contributor Author

AFCMS commented Apr 16, 2023

@GreenXenith If you validate the concept I will start making the extension use this.

@GreenXenith
Copy link
Owner

@GreenXenith If you validate the concept I will start making the extension use this.

@AFCMS Concept is good 👍

@AFCMS
Copy link
Contributor Author

AFCMS commented Apr 21, 2023

I have literally more than 30 files modified in my workspace currently, so I may push known non-working/partial changes.

@AFCMS
Copy link
Contributor Author

AFCMS commented May 31, 2023

@GreenXenith I made quite a few changes unrelated to the title of the PR (because refactoring file structure is really painful).

Could you give them a look? It should even work locally.

I added a template system for both game and mod (modpack, mod in game, modpack in game are still to be done)

They support multiple workspace folders.

I also added an option to automatically initialize a Git repository when creating a template.

My plan is also to optionally set the author field in mod.conf, etc to the Git username.

I think its OK to depend on the Git extension since its builtin in vscode/vscodium.

- Website
- ContentDB
- GitHub
- Forums
@AFCMS
Copy link
Contributor Author

AFCMS commented Jun 6, 2023

I added a basic #44 implementation. Still need a few more links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants