Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datanode.log to the support bundle #21553

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Feb 6, 2025

Added datanode.log to the support bundle. Removed opensearch stdout and stderr, these are already included in the datanode.log, which is easier to follow anyway.

Description

  • Added memory appender in datanode,
  • Added rest endpoint for the datanode.log
  • Added datanode.log handling in the support bundle
  • Removed opensearch.log and opensearch.err handlers in the support bundle

Motivation and Context

Fixes #20919

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora requested a review from moesterheld February 6, 2025 13:46
@todvora todvora marked this pull request as ready for review February 6, 2025 13:46
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the change!

Only two minor nitpicks, but they do not necessarily need to be changed.

@todvora
Copy link
Contributor Author

todvora commented Feb 7, 2025

Thanks for the review @moesterheld, fixed both of these.

@moesterheld moesterheld merged commit 2fcd968 into master Feb 7, 2025
6 checks passed
@moesterheld moesterheld deleted the feature/datanode_logs_support_bundle branch February 7, 2025 09:17
@todvora todvora restored the feature/datanode_logs_support_bundle branch February 7, 2025 14:00
@todvora todvora deleted the feature/datanode_logs_support_bundle branch February 7, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support bundle should contain data node process logs
2 participants