Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure action.destructive_requires_name in data node #18647

Closed

Conversation

moesterheld
Copy link
Contributor

Description

Due to a bug in the Opensearch client (opensearch-project/opensearch-java#894) our OS client will throw an exception when calling the nodes info endpoint when action.auto_create_index is set but action.destructive_requires_name (which should have a default value) is not.

In the data node, we can set the configuration accordingly to avoid that.

For users not using data node, a release not has been added.

Motivation and Context

see #18619

How Has This Been Tested?

Start data node without parameter set -> exception will be thrown

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@moesterheld
Copy link
Contributor Author

after talking to Dennis, we might choose a different approach and monkey patch the client. changing this back to a draft pr

@moesterheld moesterheld marked this pull request as draft March 15, 2024 08:55
@moesterheld
Copy link
Contributor Author

monkey-patched in #18658

@moesterheld moesterheld deleted the configure-action-destructive-requires-name branch March 15, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant