distribution snapper overhaul #2626
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moOsama76
commented
Apr 30, 2025
•
moOsama76
commented
- Fix distribution snapper visualization going far from layers Distribution snappers are correctly positioned based on mouse position instead of tracked object. #2614
- Fix bug where center point and corner point have to be enabled for distribution snapper to work
- Fix tests
- Improving naming conventions and comments
Keavon
changed the title
moOsama76
force-pushed
the
distribution_snapper_bug
branch
from
fe0721c to
029806f
Compare
|
I think this issue is more complex than it looks, any change in the variables the draw those visualizations will fails tests |
|
If that's because you can identify that the tests encode incorrect behavior, please fix the tests alongside your change. |
Sure |
…stribution_snapper to work
moOsama76
force-pushed
the
distribution_snapper_bug
branch
from
38b218c to
d6a4aad
Compare
moOsama76
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.