Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Pen tool's colinearity and equidistance controls #2242

Merged
merged 24 commits into from
Feb 5, 2025

Conversation

0SlowPoke0
Copy link
Contributor

@0SlowPoke0 0SlowPoke0 commented Jan 31, 2025

Parly closes #1870

  1. C toggles bent vs. colinear handles (instead of the momentary Alt in use now)
  2. Alt stops keeping the handles equidistant while pressed, as long as they're currently colinear (otherwise it does nothing) and also covers its exception
  3. Preserve collinearity while in GRS mode
  4. Closes Use KeyNoRepeat instead of Key to avoid potential user confusion that Tab shouldn't be held in to swap dragged handles #2253
  5. When drawing the next segment (mouse is up), Ctrl is down to lock the angle, if you hover over the anchor point, the locked direction changes discord

@Keavon
Copy link
Member

Keavon commented Jan 31, 2025

!build

Copy link

📦 Build Complete for 5109b12
https://5c195c08.graphite.pages.dev

@Keavon Keavon changed the title Pen tool improvements Improve the Pen tool's colinearity and equidistance controls Jan 31, 2025
@0SlowPoke0 0SlowPoke0 marked this pull request as ready for review February 1, 2025 09:02
Copy link
Member

@0HyperCube 0HyperCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems well structured.

editor/src/messages/tool/tool_messages/pen_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/pen_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/pen_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/pen_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/pen_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/pen_tool.rs Outdated Show resolved Hide resolved
@Keavon Keavon merged commit 41ee1cf into GraphiteEditor:master Feb 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants