Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape tools set node params without using transformation of unit shapes #2236

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Nitish-bot
Copy link
Contributor

@Nitish-bot Nitish-bot commented Jan 29, 2025

Closes #2090

The tools:
  • Line
  • Rectangle
  • Ellipse
  • Polygon
  • Star

@Nitish-bot Nitish-bot force-pushed the shape-tools-node-params branch from 05bf4a0 to fb86e46 Compare January 31, 2025 21:32
@Nitish-bot Nitish-bot marked this pull request as ready for review January 31, 2025 21:32
Copy link
Contributor Author

@Nitish-bot Nitish-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit cd9fca1 is fixing the ellipse tool not the text tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The shape tools should set shape node parameters, not transformations of unit shapes
1 participant