Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the transform cage show/hide resize grips as space allows #2209

Merged
merged 18 commits into from
Jan 30, 2025

Conversation

mTvare6
Copy link
Contributor

@mTvare6 mTvare6 commented Jan 20, 2025

@mTvare6 mTvare6 marked this pull request as draft January 20, 2025 11:28
@mTvare6 mTvare6 marked this pull request as ready for review January 22, 2025 03:47
@Keavon
Copy link
Member

Keavon commented Jan 23, 2025

!build

Copy link

📦 Build Complete for 0e97316
https://cb40c13a.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Jan 23, 2025

I'm QA testing this and for the life of me, I cannot figure out what the logic is behind when the center drag handles disappear or remain. It seems to be entirely random, sometimes the handles stick around and other times they go away, at completely unpredictable times. That will have to be solved.

The localized rotation regions feature is looking good.

@Keavon Keavon marked this pull request as draft January 23, 2025 23:58
@Keavon Keavon changed the title Changes rotation handles to be around overlay squares Improve transform cage with size-dependent resize grips and grip-local (no longer edge-local) rotation Jan 23, 2025
@mTvare6 mTvare6 marked this pull request as ready for review January 24, 2025 11:59
@Keavon
Copy link
Member

Keavon commented Jan 25, 2025

!build

Copy link

📦 Build Complete for bdcadb4
https://bdbcbd43.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Jan 25, 2025

capture

Looks like you've correctly implemented the "hide centers" one but I don't see "hide corners" working when I shrink it even further. But it does seem that it works for straight lines. I've tested this just by scaling down a rectangle.

I also found a bug that will need solving:

capture_42_.mp4

In my second try in this video, you see that it grabs the wrong resize grip— the top one, even though I'm dragging from below. There will need to be some logic to ensure that the closest grip is selected if multiple are within range.

@Keavon Keavon marked this pull request as draft January 25, 2025 03:16
@mTvare6 mTvare6 force-pushed the 1d-transformation-cage branch from f17a98d to 40f459d Compare January 25, 2025 09:11
@mTvare6 mTvare6 marked this pull request as ready for review January 25, 2025 11:25
@Keavon Keavon marked this pull request as draft January 26, 2025 01:42
@Keavon
Copy link
Member

Keavon commented Jan 26, 2025

@Keavon
Copy link
Member

Keavon commented Jan 27, 2025

!build

Copy link

📦 Build Complete for bde2c4e
https://7d74b250.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Jan 27, 2025

!build

Copy link

📦 Build Complete for d4fafbc
https://b56ac0bf.graphite.pages.dev

@mTvare6 mTvare6 marked this pull request as ready for review January 27, 2025 16:36
@Keavon
Copy link
Member

Keavon commented Jan 29, 2025

!build

Copy link

📦 Build Complete for 3ca503b
https://60f70f33.graphite.pages.dev

@Keavon Keavon changed the title Improve transform cage with size-dependent resize grips and grip-local (no longer edge-local) rotation Make the transform cage show/hide resize grips as space allows Jan 29, 2025
@Keavon
Copy link
Member

Keavon commented Jan 29, 2025

!build

Copy link

📦 Build Complete for 9c142e2
https://52955284.graphite.pages.dev

@mTvare6 mTvare6 force-pushed the 1d-transformation-cage branch from 8c90cd7 to 858bf96 Compare January 29, 2025 09:14
@Keavon
Copy link
Member

Keavon commented Jan 29, 2025

!build

Copy link

📦 Build Complete for 858bf96
https://fb2ad702.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Jan 29, 2025

Please use a value of 40 for the height at which the insides become not scalable.

@Keavon
Copy link
Member

Keavon commented Jan 29, 2025

!build

Copy link

📦 Build Complete for 324941f
https://e62f8df6.graphite.pages.dev

@Keavon Keavon enabled auto-merge (squash) January 30, 2025 00:59
@Keavon Keavon merged commit a0f8f89 into GraphiteEditor:master Jan 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants